Closed
Conversation
amoghrajesh
approved these changes
Jun 5, 2025
Contributor
amoghrajesh
left a comment
amoghrajesh
left a comment
There was a problem hiding this comment.
Lets merge this and investigate separately why things are so off.
vincbeck
force-pushed
the
vincbeck/fab_assets
branch
from
954b80b to
f9fb015
Compare
vincbeck
commented
Jun 5, 2025
| - id: compile-fab-assets | ||
| name: Compile FAB provider assets | ||
| language: node | ||
| 'types_or': [javascript, ts, tsx] |
Contributor
Author
There was a problem hiding this comment.
This is why sometimes the assets are not generated. If you modify package.json which define the dependencies, it wont regenerate the assets, although it should. Removing this filter fixes the issue
Contributor
Author
There was a problem hiding this comment.
Nevermind, this is not the root cause. But we still should remove it for local development
Contributor
Author
|
Closing in favor of #51446 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.